Skip to content

Fix: Allowing Empty UserID as valid field #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 27, 2018
Merged

Fix: Allowing Empty UserID as valid field #220

merged 10 commits into from
Nov 27, 2018

Conversation

@mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Sep 27, 2018

No description provided.

@coveralls
Copy link

coveralls commented Sep 27, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 773

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 89.91%
Files with Coverage Reduction New Missed Lines %
core-api/src/main/java/com/optimizely/ab/Optimizely.java 1 93.31%
Totals Coverage Status
Change from base Build 770: -0.04%
Covered Lines: 2691
Relevant Lines: 2993
💛 - Coveralls
thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But, I still question whether we should allow empty user ids as valid.
@mnoman09
Copy link
Contributor Author

mnoman09 commented Nov 27, 2018

@thomaszurkan-optimizely Yes there are testcases of checking empty user id as valid added in fullstack compatibility suite. @mikeng13 can you please elaborate further.
@mikeproeng37
Copy link
Contributor

mikeproeng37 commented Nov 27, 2018

Yeah we decided at some point to allow empty strings as they are a valid way to use the API. They result in a valid bucketing number and kind of serves as a way to allow binary ON/OFF usage of APIs like isFeatureEnabled where the developer doesn't have to deal with user IDs
@mikeproeng37 mikeproeng37 merged commit 8e3dafc into master Nov 27, 2018
@mnoman09 mnoman09 deleted the mnoman/AllowingEmptyUserId branch January 18, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@mnoman09 @coveralls @mikeproeng37 @thomaszurkan-optimizely