Skip to content

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

  • Cherry-picked from main branch bug fix
  • Updated versions numbers including missed one
  • Add changelog update

Test plan

  • All unit tests and e2e non-AAT tests should pass
  • ODP e2e tests will be temporarily turned off

Issues

  • FSSDK-9538
* Fix non-RFC1123 formatting * Update tests to ensure expected format * Add more accurate assert * Lint fixes (cherry picked from commit 962bd68)
I can't believe I missed the main project fully 😫
@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review July 28, 2023 17:32
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner July 28, 2023 17:32
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely merged commit 9e08223 into release-3.11.4 Jul 28, 2023
@mikechu-optimizely mikechu-optimizely deleted the mike/pick-prep-3.11.4 branch July 28, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants