Skip to content

feat: Added ODPSegmentManager #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Nov 23, 2022
Merged

feat: Added ODPSegmentManager #321

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d9db9a5
WIP Initial SegmentManager commit
mikechu-optimizely Nov 4, 2022
e5fcd9a
WIP Initial commit fixes
mikechu-optimizely Nov 4, 2022
61d3e0f
WIP Initial commit fixes
mikechu-optimizely Nov 4, 2022
c4db70a
Finish OdpSegmentManager & interface
mikechu-optimizely Nov 8, 2022
b79861e
WIP unit tests starts
mikechu-optimizely Nov 8, 2022
bc60e1f
Unit tests & Segment Manager edits
mikechu-optimizely Nov 9, 2022
38281ab
Merge branch 'master' into mike/odp-segment-manager
mikechu-optimizely Nov 16, 2022
164b9d6
Merge branch 'master' into mike/odp-segment-manager
mikechu-optimizely Nov 18, 2022
4f62cd7
Fix merge issues; Add unit test
mikechu-optimizely Nov 18, 2022
a614e9f
Lint fixes
mikechu-optimizely Nov 18, 2022
a42ed21
Lint fixes?
mikechu-optimizely Nov 18, 2022
7efe971
Lint fixes??
mikechu-optimizely Nov 18, 2022
8b4f002
Lint fixes???
mikechu-optimizely Nov 18, 2022
3d27572
Remove re-added IOdpConfig.cs
mikechu-optimizely Nov 18, 2022
1c5a914
Add internal doc
mikechu-optimizely Nov 18, 2022
9d61e43
PR code review revisions
mikechu-optimizely Nov 22, 2022
40f2fdf
Update unit test
mikechu-optimizely Nov 22, 2022
3f91f81
Update OptimizelySDK/Odp/OdpSegmentManager.cs
mikechu-optimizely Nov 22, 2022
be49cb1
Pull request code revisions
mikechu-optimizely Nov 22, 2022
892cd3f
Remove time complexity looping/Linq
mikechu-optimizely Nov 23, 2022
77d56dd
Small refactor
mikechu-optimizely Nov 23, 2022
eedf603
Use OrderedDictionary
mikechu-optimizely Nov 23, 2022
ec81354
Use OrderedDictionary
mikechu-optimizely Nov 23, 2022
fe6a6d8
Merge remote-tracking branch 'origin/mike/odp-segment-manager' into m…
mikechu-optimizely Nov 23, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update unit test
  • Loading branch information
@mikechu-optimizely
mikechu-optimizely committed Nov 22, 2022
commit 40f2fdfab71421fecf3d21058747f80ae596a16b
4 changes: 2 additions & 2 deletions OptimizelySDK.Tests/OdpTests/OdpSegmentManagerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public void ShouldHandleFetchSegmentsWithError()
}

[Test]
public void ShouldLogAndReturnEmptySegmentsListWhenOdpConfigNotReady()
public void ShouldLogAndReturnNullWhenWhenOdpConfigNotReady()
{
var mockOdpConfig = new Mock<OdpConfig>(API_KEY, API_HOST, new List<string>(0));
mockOdpConfig.Setup(o => o.IsReady()).Returns(false);
Expand All @@ -150,7 +150,7 @@ public void ShouldLogAndReturnEmptySegmentsListWhenOdpConfigNotReady()

var segments = manager.FetchQualifiedSegments(FS_USER_ID);

Assert.IsTrue(segments.Count == 0);
Assert.IsNull(segments);
_mockLogger.Verify(
l => l.Log(LogLevel.WARN, Constants.ODP_NOT_INTEGRATED_MESSAGE),
Times.Once);
Expand Down