feat(flag-decisions): Add support for sending flag decisions along with decision metadata. #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Removed extra log, - Added metadata
msohailhussain suggested changes Sep 28, 2020
| if (userEvent == null) | ||
| { | ||
| Logger.Log(LogLevel.ERROR, @"Experiment has ""Launched"" status so not dispatching event during activation."); | ||
| return; |
There was a problem hiding this comment.
I think we should log at this point.
msohailhussain changed the title 
optimizely-codereview-bot added 🤖 16 hrs 🤖 20 hrs 🤖 24 hrs and removed 🤖 12 hrs 🤖 16 hrs 🤖 20 hrs labels 
pawels-optimizely suggested changes Oct 9, 2020
There was a problem hiding this comment.
please adjust it to a new metadata: https://optimizely.atlassian.net/browse/OASIS-7050
optimizely-codereview-bot requested review from msohailhussain and pawels-optimizely refact decision source condition
optimizely-codereview-bot added 🤖 4 hrs 🤖 8 hrs 🤖 12 hrs and removed 🤖 4 hrs 🤖 8 hrs labels 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Metadatafield to EventBatch.Decisions to capture flag type, key and variation key.Test plan