fix: fix an issue that multi-arch images cannot be built from the project makefile #6661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ject makefile Signed-off-by: kurokobo <2920259+kurokobo@users.noreply.github.com>
everettraven approved these changes Jan 22, 2024
There was a problem hiding this comment.
Thanks for this contribution @kurokobo ! The changes look good to me visually. Approving and merge will be pending successful CI checks
/lgtm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #6660
This is the first time for me to send PR to this repository. Please let me know if I'm on the wrong way.
I wasn't sure if a changelog was necessary, but I wrote one anyway.
Thanks in advance 😃
Description of the change:
Fix an issue that multi-arch images cannot be built from the project Makefile, by following two changes:
testtarget fromdocker-buildxtargetsedcommand that adds--platform=${BUILDPLATFORM}so that${TARGETPLATFORM}is specified as--platformaccording to BuildKit defaultsMotivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs