Skip to content

Fix bug in cluster scoped ansible operators #4850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2021
Merged

Fix bug in cluster scoped ansible operators #4850

merged 1 commit into from
May 3, 2021

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Apr 30, 2021

Dependent object creation passing through the proxy failed to add an
owner annotation, causing the objects not to be watched.

Closes #4647

Signed-off-by: austin austin@redhat.com

Checklist

If the pull request includes user-facing changes, extra documentation is required:
@asmacdo
Fix bug in cluster scoped ansible operators
de44fb4 
Dependent object creation passing through the proxy failed to add an owner annotation, causing the objects not to be watched. Signed-off-by: austin <austin@redhat.com>
fabianvf
fabianvf reviewed Apr 30, 2021
View reviewed changes
internal/ansible/proxy/inject_owner.go
data.SetOwnerReferences(append(data.GetOwnerReferences(), owner.OwnerReference))
} else {
err := handler.SetOwnerAnnotations(data, ownerObject)
err := handler.SetOwnerAnnotations(ownerObject, data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧇 🌮 🍟
@fabianvf
Copy link
Member

/lgtm
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2021
jmrodri
jmrodri approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
internal/ansible/proxy/inject_owner.go
data.SetOwnerReferences(append(data.GetOwnerReferences(), owner.OwnerReference))
} else {
err := handler.SetOwnerAnnotations(data, ownerObject)
err := handler.SetOwnerAnnotations(ownerObject, data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧇 🌮 🍟
@asmacdo asmacdo merged commit c411820 into operator-framework:master May 3, 2021
@asmacdo
Copy link
Member Author

asmacdo commented May 3, 2021

/cherrypick 1.7.x
/cherrypick 1.6.x
/cherrypick 1.5.x
@openshift-cherrypick-robot
Copy link

@asmacdo: cannot checkout 1.7.x: error checking out 1.7.x: exit status 1. output: error: pathspec '1.7.x' did not match any file(s) known to git

In response to this:

/cherrypick 1.7.x
/cherrypick 1.6.x
/cherrypick 1.5.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@asmacdo
Copy link
Member Author

asmacdo commented May 3, 2021

/cherrypick v1.7.x
@asmacdo
Copy link
Member Author

asmacdo commented May 3, 2021

/cherrypick v1.6.x
@asmacdo
Copy link
Member Author

asmacdo commented May 3, 2021

/cherrypick v1.5.x
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 3, 2021
Closed
@openshift-cherrypick-robot
Copy link

@asmacdo: new pull request created: #4857

In response to this:

/cherrypick v1.7.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 3, 2021
Merged
@openshift-cherrypick-robot
Copy link

@asmacdo: new pull request created: #4858

In response to this:

/cherrypick v1.6.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 3, 2021
Closed
@openshift-cherrypick-robot
Copy link

@asmacdo: new pull request created: #4859

In response to this:

/cherrypick v1.5.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@slopezz slopezz mentioned this pull request Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

5 participants

@asmacdo @fabianvf @openshift-cherrypick-robot @jmrodri @openshift-ci-robot