{ansible,helm}-operator run: add component config flag --config #4776
Conversation
openshift-ci-robot added the kind/bug 
estroz force-pushed the bugfix/support-cr-config branch 2 times, most recently from c9e82fe to a5adfef Compare 
ansible-operator and helm-operator by adding the underlying reading and Manager option updating functionality. This was missing when the config file was originally added to both ansible/v1 and helm/v1 plugins. --config accepts a path to this config file. internal/{ansible,helm}: add --config flag, and configure existing flags to be applied on top of manager Options internal/cmd/{ansible,helm}: apply config file data prior to flag data Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com> | const ( | ||
| AnsibleRolesPathEnvVar = "ANSIBLE_ROLES_PATH" | ||
| AnsibleCollectionsPathEnvVar = "ANSIBLE_COLLECTIONS_PATH" | ||
| ) |
There was a problem hiding this comment.
Nit: Many changes here are more refractory and cleanups. I am ok with move with that. But it might be better to be done in a diff pr since is a bug fix. However, that is fine too. (might not valuble the effort to split)
There was a problem hiding this comment.
We are doing some cleanups together here but I do not think that is valid the effort to split in another pr. So, that's is OK for me 👍
Nit: We might need to change the PR title since we are no longer change the scaffolds here (just because that goes in the git log)
Otherwsise,
/lgtm
Really thank you for address these bug fixes so fast.
Great work btw 🥇
estroz changed the title {ansible,helm}-operator run: add component config flag --config Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
estroz force-pushed the bugfix/support-cr-config branch from a5adfef to 27e6232 Compare 
| New changes are detected. LGTM label has been removed. |
| Added some unit tests. |
| /cherry-pick v1.6.x |
| @estroz: new pull request created: #4780 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
Motivation for the change: This PR fixes manager component configuration for ansible-operator and helm-operator by adding the underlying reading and Manager option updating functionality. This was missing when the config file was originally added to both ansible/v1 and helm/v1 plugins. --config accepts a path to this config file.
/kind bug
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs