ansible/helm: add makefile helper #4660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| seems to work fine. I worry about this just being text in a template somewhere, though - one more thing we have to remember to update if anything changes. |
camilamacedo86 requested review from estroz, rashmigottipati and varshaprasad96 
estroz reviewed Mar 16, 2021
estroz suggested changes Mar 16, 2021
Comment on lines 33 to 36
| Ansible/Helm projects scaffolded by the tool now provides a Makefile | ||
| helper. To address these changes you can copy and paste the Makefile from | ||
| its samples which are in the testdata. Check the latest version of the | ||
| Helm Makefile [here](https://github.com/operator-framework/operator-sdk/blob/v1.6.0/testdata/helm/memcached-operator/Makefile) and check it for Ansible [here](https://github.com/operator-framework/operator-sdk/blob/v1.6.0/testdata/ansible/memcached-operator/Makefile). |
There was a problem hiding this comment.
Suggested change
| Ansible/Helm projects scaffolded by the tool now provides a Makefile | |
| helper. To address these changes you can copy and paste the Makefile from | |
| its samples which are in the testdata. Check the latest version of the | |
| Helm Makefile [here](https://github.com/operator-framework/operator-sdk/blob/v1.6.0/testdata/helm/memcached-operator/Makefile) and check it for Ansible [here](https://github.com/operator-framework/operator-sdk/blob/v1.6.0/testdata/ansible/memcached-operator/Makefile). | |
| Ansible/Helm projects now provide a Makefile `help` target, similar to a `--help` flag. | |
| You can copy and paste this target from the relevant sample's Makefile | |
| ([helm]((https://github.com/operator-framework/operator-sdk/blob/v1.5.0/testdata/helm/memcached-operator/Makefile), [ansible]((https://github.com/operator-framework/operator-sdk/blob/v1.5.0/testdata/ansible/memcached-operator/Makefile)). |
| # Migration can be defined to automatically add a section to | ||
| # the migration guide. This is required for breaking changes. | ||
| migration: | ||
| header: (helm/v1,ansible/v1) - **(Optional)** Add Makefile helper |
There was a problem hiding this comment.
Suggested change
| header: (helm/v1,ansible/v1) - **(Optional)** Add Makefile helper | |
| header: (helm/v1, ansible/v1) Add `help` target to Makefile. |
estroz reviewed Mar 16, 2021
Comment on lines 118 to 120
| .PHONY: kustomize ## Download kustomize locally if necessary. | ||
| KUSTOMIZE = $(shell pwd)/bin/kustomize | ||
| kustomize: |
There was a problem hiding this comment.
Suggested change
| .PHONY: kustomize ## Download kustomize locally if necessary. | |
| KUSTOMIZE = $(shell pwd)/bin/kustomize | |
| kustomize: | |
| .PHONY: kustomize | |
| KUSTOMIZE = $(shell pwd)/bin/kustomize | |
| kustomize: ## Download kustomize locally if necessary. |
estroz reviewed Mar 16, 2021
Comment on lines 134 to 136
| .PHONY: ansible-operator ## Download ansible-operator locally if necessary, preferring the $(pwd)/bin path over global if both exist. | ||
| ANSIBLE_OPERATOR = $(shell pwd)/bin/ansible-operator | ||
| ansible-operator: |
There was a problem hiding this comment.
Suggested change
| .PHONY: ansible-operator ## Download ansible-operator locally if necessary, preferring the $(pwd)/bin path over global if both exist. | |
| ANSIBLE_OPERATOR = $(shell pwd)/bin/ansible-operator | |
| ansible-operator: | |
| .PHONY: ansible-operator | |
| ANSIBLE_OPERATOR = $(shell pwd)/bin/ansible-operator | |
| ansible-operator: ## Download ansible-operator locally if necessary, preferring the $(pwd)/bin path over global if both exist. |
Signed-off-by: Camila Macedo <cmacedo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Camila Macedo cmacedo@redhat.com
Description of the change:
add makefile helper for ansible/helm
Motivation for the change:
provide for ansible/helm the same nice features that we have for Go
Closes: #4628
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs