Skip to content

Conversation

estroz
Copy link
Member

@estroz estroz commented Mar 10, 2021

Description of the change:

Motivation for the change: recent changes in kubebuilder

Closes #4468

/area dependency

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci-robot openshift-ci-robot added the area/dependency Issues or PRs related to dependency changes label Mar 10, 2021
@estroz estroz temporarily deployed to deploy March 10, 2021 00:40 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 00:40 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 00:40 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 00:40 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 00:40 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 00:40 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 01:37 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 01:37 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 01:37 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 01:37 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 01:37 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 01:37 Inactive
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit/suggestion to improve the changelog. See: https://github.com/operator-framework/operator-sdk/pull/4626/files#r590915456.
Otherwise it shows ok for me 👍

I checked the changes upstream from one version to another and all shows fine too.
I mean, all required entries are addressed in the changelog.

Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
@estroz estroz temporarily deployed to deploy March 10, 2021 02:16 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 02:16 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 02:16 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 02:16 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 02:16 Inactive
@estroz estroz temporarily deployed to deploy March 10, 2021 02:16 Inactive
@estroz estroz added this to the v1.5.0 milestone Mar 10, 2021
@estroz estroz merged commit ea7eafe into operator-framework:master Mar 10, 2021
@estroz estroz deleted the deps/bump-kb branch March 10, 2021 02:44
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm


**Note:** The version of [controller-runtime][controller-runtime] used in the projects scaffolded by SDK `0.19.x+` was `v0.6.0`. Please check [sigs.k8s.io/controller-runtime release docs from 0.7.0+ version][controller-runtime] for breaking changes.

##### Updating your ServiceAccount in Go operator projects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estroz I just realized that in Go operator projects is not required here. See that it is the Golang migration guide so it is all about Go-based operators. Also, should we not add any info in the https://master.sdk.operatorframework.io/docs/building-operators/golang/operator-scope/ docs as well?
Also, I think we need to update ansible and helm before 1.5 regards this one too for doing no start o b very confuse.

reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Mar 11, 2021
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Mar 11, 2021
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>

```console
$ operator-sdk scorecard <bundle_dir_or_image> --service-account=mycustomsa
$ operator-sdk scorecard <bundle_dir_or_image> --service-account=my-project-controller-manager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estroz just to share. See that this document is for all types. we changed the behaviour for GO and now it deviates from Ansible/Helm. If we do not apply the same changes for Ansible/Helm this doc is no longer valid for them.

c/c @jmrodri

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, since the service account name is arbitrary.

camilamacedo86 added a commit that referenced this pull request Mar 18, 2021
**Description of the change:** - create and bind to a non-default service account - follow up : kubernetes-sigs/kubebuilder#2070 and #4626 **Motivation for the change:** - fix: Scorecard docs instructions are wrong now for Ansible/Helm - rfe: apply the same go behaviour of Go default config for Ansible/Helm - Reduce the complexities for we address kubernetes-sigs/kubebuilder#2015 - Keep Ansible/Helm/Go aligned (Align Helm/Ansible plugins with the changes made for Golang ( go/v3 )) Closes: #4644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Issues or PRs related to dependency changes

4 participants