(manifests/v2) add catalog targets to Makefile #4406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
estroz force-pushed the feature/build-catalog branch from 403b99c to 9ffbb58 Compare 
| @camilamacedo86 this is the |
estroz force-pushed the feature/build-catalog branch from 9ffbb58 to f8a08b7 Compare 
estroz force-pushed the feature/build-catalog branch 2 times, most recently from 8853d20 to 215f778 Compare 
estroz force-pushed the feature/build-catalog branch from 215f778 to 21b7891 Compare 
targets to Makefile Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
estroz force-pushed the feature/build-catalog branch from 21b7891 to a075a66 Compare estroz changed the title 
openshift-ci-robot added the do-not-merge/hold | # https://github.com/operator-framework/community-operators/blob/7f1438c/docs/packaging-operator.md#updating-your-existing-operator | ||
| .PHONY: catalog-build | ||
| catalog-build: opm ## Build a catalog image. | ||
| $(OPM) index add --mode semver --tag $(CATALOG_IMG) --bundles $(BUNDLE_IMGS) $(FROM_INDEX_OPT) |
There was a problem hiding this comment.
$ make catalog-build
./bin/opm index add --mode semver --tag my.domain/testcas-catalog:v0.0.1 --bundles my.domain/testcas-bundle:v0.0.1
INFO[0000] building the index bundles="[my.domain/testcas-bundle:v0.0.1]"
Error: Binary was compiled with 'CGO_ENABLED=0', go-sqlite3 requires cgo to work. This is a stub
Usage:
opm index add [flags]
There was a problem hiding this comment.
How did you install opm? It looks like you installed it from source locally, since the released binaries are all installed with CGO_ENABLED=1.
openshift-ci-robot removed the do-not-merge/hold This was referenced Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of the change:
catalog-build,catalog-push, andopmtargets to Makefile, and improve variables/comments for ease of use.Motivation for the change: this addition to the Makefile allows users to create catalog images with
opm index add. They can string togethermakerules like so:or if
IMAGE_TAG_BASEis set to an existing repo:export IMAGE_TAG_BASE=quay.io/example/my-operator make bundle-build bundle-push catalog-build catalog-pushwhich will build and push
quay.io/example/my-operator-bundle:v0.0.1andquay.io/example/my-operator-catalog:v0.0.1.Enhancement: enhancements/operator-sdk-builds-catalogs.md
Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs