internal/plugins/manifests: inject operator image using IMG=<tag> #3634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ntroller=$(IMG)` to the manifests phase 2 plugin's Makefile modifier, such that a user can specify operator image using `make bundle IMG=<tag>`. internal/plugins/manifests: add `IMG` variable injection to `bundle` recipe test/: update tests to use `IMG=<test image tag>` website/: update OLM integration docs with this change
openshift-ci-robot requested review from asmacdo, camilamacedo86, fabianvf and joelanford 
joelanford reviewed Aug 3, 2020
joelanford reviewed Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of the change:
IMGvariable injection tobundlerecipeIMG=<test image tag>Motivation for the change: This PR adds
cd config/manager && $(KUSTOMIZE) edit set image controller=$(IMG)to the manifests phase 2 plugin's Makefile modifier, such that a user can specify operator image usingmake bundle IMG=<tag>. Our e2e tests were passing becausemake deploy IMG=<tag>was run beforehand; in a newly scaffolded project that only uses bundles/package manifests, that will likely not be the case./cc @joelanford @camilamacedo86 @asmacdo @fabianvf
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs