Move pkg/k8sutil to internal/k8sutil #3475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove all public APIs from SDK to prepare for v1.0.0
hasbro17 requested review from estroz, jmccormick2001, joelanford and varshaprasad96 
camilamacedo86 approved these changes Jul 21, 2020
| Should we combine |
| @joelanford Good point, I would say yes. I'll move it to |
| New changes are detected. LGTM label has been removed. |
bartoszmajsak added a commit to maistra/istio-workspace that referenced this pull request Sep 25, 2020
Introduces our own getWatchNamespace func See operator-framework/operator-sdk#3475
bartoszmajsak added a commit to maistra/istio-workspace that referenced this pull request Jan 14, 2021
Introduces our own getWatchNamespace func See operator-framework/operator-sdk#3475
aslakknutsen pushed a commit to maistra/istio-workspace that referenced this pull request Jan 19, 2021
Introduces our own getWatchNamespace func See operator-framework/operator-sdk#3475
skitt added a commit to skitt/submariner-operator that referenced this pull request Dec 14, 2021
k8sutil is no longer exported by the Operator SDK (see <operator-framework/operator-sdk#3475>). Instead of using k8sutil.GetWatchNamespace(), use our own implementation, as explained on https://sdk.operatorframework.io/docs/building-operators/golang/operator-scope/#configuring-namespace-scoped-operators Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt added a commit to skitt/submariner-operator that referenced this pull request Dec 15, 2021
k8sutil is no longer exported by the Operator SDK (see <operator-framework/operator-sdk#3475>). Instead of using k8sutil.GetWatchNamespace(), use our own implementation, as explained on https://sdk.operatorframework.io/docs/building-operators/golang/operator-scope/#configuring-namespace-scoped-operators Signed-off-by: Stephen Kitt <skitt@redhat.com>
dfarrell07 pushed a commit to submariner-io/submariner-operator that referenced this pull request Dec 16, 2021
k8sutil is no longer exported by the Operator SDK (see <operator-framework/operator-sdk#3475>). Instead of using k8sutil.GetWatchNamespace(), use our own implementation, as explained on https://sdk.operatorframework.io/docs/building-operators/golang/operator-scope/#configuring-namespace-scoped-operators Signed-off-by: Stephen Kitt <skitt@redhat.com>
This was referenced Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of the change:
Move
pkg/k8sutiltointernal/k8sutilto remove public APIs forv1.0.0releaseMotivation for the change:
Related to #3327