feat: add helm plugin scaffolding new layout #3421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Started in; #3295 ( I close to test the CI in my fork and I could not re-open ) |
asmacdo reviewed Jul 14, 2020
estroz reviewed Jul 14, 2020
joelanford reviewed Jul 14, 2020
joelanford reviewed Jul 15, 2020
joelanford reviewed Jul 15, 2020
| /retest |
openshift-ci-robot added the needs-rebase 
openshift-ci-robot removed the needs-rebase 
This was referenced Jul 15, 2020
92 tasks
camilamacedo86 added a commit that referenced this pull request Jul 18, 2020
**Description of the change:** Provide the same documentation and steps using the helm plugin. See the PR #3421 which adds the plugin. - Update all related info in the Helm documentation - Create a new sub-directory called Legacy to keep the previous docs **Motivation** SDK is in a process to be integrated with KB which means that its project layouts will be aligned. More info : [Integrating Kubebuilder and Operator SDK](https://github.com/kubernetes-sigs/kubebuilder/blob/master/designs/integrating-kubebuilder-and-osdk.md) and [Extensible CLI and Scaffolding Plugins](https://github.com/kubernetes-sigs/kubebuilder/blob/master/designs/extensible-cli-and-scaffolding-plugins-phase-1.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR adds the helm plugin scaffolding the files with the new layout and using the current sdk helm pkg implementation (image)
/test/e2e-helm-new/e2e_suite.goand./hack/tests/e2e-helm-new.shhack/tests/e2e-helm.shMotivation
SDK is in a process to be integrated with KB which means that its project layouts will be aligned. More info : Integrating Kubebuilder and Operator SDK.
This PR adds the Helm Plugin which will provide the Helm project in the new layout by the command
operator-sdk init --plugins=helm.operator-sdk.io/v1`. For a further understanding see the WIP: #329 and the doc Extensible CLI and Scaffolding Plugins.Follow-ups
operator-sdk new --type and add apicommands - Done in: docs: update helm docs for the new layout #3326operator-sdk new --type=-helmremoval: helm legacy scaffold #3343