- Notifications
You must be signed in to change notification settings - Fork 1.8k
[docs] Reorganize hugo doc site #3382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Reorganize hugo doc site #3382
Conversation
f7ec7c6
to 88fb147
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anik120,
really tks for the contribution. Ask we spoke in the slack. Could we not slit it by section to make the process work easy and fast? E.g ansible, golang an etc
Also, not that it is not passing in the CI. The changes performed here broke the links.
This comment has been minimized.
This comment has been minimized.
Also, I think
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main issue is with the Core Tasks
menu seems odd for the SDK. The heading font is different size than the one on the OLM site, and I don't like the "Getting Started" nav title since it's really "Installing or Installation" that is being described.
I think I know why |
website/content/en/docs/core-tasks/bumping-sdk-version/_index.md Outdated Show resolved Hide resolved
website/content/en/docs/core-tasks/bumping-sdk-version/version-upgrade-guide.md Outdated Show resolved Hide resolved
website/content/en/docs/core-tasks/bumping-sdk-version/version-upgrade-guide.md Show resolved Hide resolved
website/content/en/docs/core-tasks/bumping-sdk-version/v0.1.0-migration-guide.md Outdated Show resolved Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
88fb147
to 802fb0e
Compare 802fb0e
to bb4bbc1
Compare This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bb4bbc1
to 464c157
Compare 464c157
to 8b18644
Compare Hi @anik120, It still not passing in the CI. We cannot merge without that. Regards the sanity check
Regards the docs |
1560c6c
to 5f58a4b
Compare af0e585
to cb4ef64
Compare @camilamacedo86 could you take a look now please. I've fixed most of it, there's a lot of external links that are broken. Not sure if I have to do anything about that in this PR. |
tons of broken links because of all the churn happening in master with legacy being removed.
|
And now there is a conflict so this PR needs a rebase |
d8022e8
to 2b366c4
Compare @camilamacedo86 @jmrodri resolved all the broken links expect for these two and looks like they're broken in main branch too. |
2b366c4
to d8e6a82
Compare Hi @anik120, See that it is not passing in the CI because of broken links. However, not that your PR/version is missing docs and it is not accurate. Something probably was wrong in your rebase. To check the broking links see the error msg:
It means that the The same for the other scenario:
It means that the Also, see that something goes wrong in your rebase: The scorecard should be a menu with its docs instead that. Also, see that its cli index doc is also in the root when should not. You might need to review the changes made in the script to update the cli docs. See the master branch docs to check how it should be: |
ecb59d6
to 8af3dca
Compare | ||
**Note:** For Golang Operators this CLI has been deprecated. Please consult the [new CLI reference][new_CLI] doc. | ||
| ||
[new_CLI]:/docs/cli/new-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect link:
[new_CLI]:/docs/cli/new-cli | |
[new_CLI]:/docs/new-cli |
We might want to wait until #3455 is merged to simplify this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, we can merge #3455 after this one is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estroz yea that'd be appreciated this PR has been in the works for a week now.
Although, CI job request is still pending for this one.
| ||
**Note:** This CLI reference is for the new Kubebuilder aligned CLI and project layout. See the [legacy CLI reference][legacy_cli] doc if using a legacy Golang project. | ||
| ||
[legacy_CLI]:/docs/cli/legacy-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[legacy_CLI]:/docs/cli/legacy-cli | |
[legacy_CLI]:/docs/cli |
This PR reorganizes sdk.operatorframework.io to match the navigation panel for olm.operatorframework.io, so that both the sites appear to be part of one operator-framework family.
8af3dca
to a33c70b
Compare /lgtm |
shows that the changes requested was made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shows OK for me 👍
Tks for your commitment with that 🥇
/lgtm
Description of the change:
This PR reorganizes sdk.operatorframework.io to match the navigation
panel for olm.operatorframework.io, so that both the sites appear
to be part of one operator-framework family.
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs