Skip to content

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Apr 27, 2020

Description of the change:

  1. Update Kubernetes deps to 1.18
  2. Update controller-runtime to 0.6.0
  3. Update controller-tools to 0.3.0
  4. Update Helm to 3.2.0
    • Removed support for legacy UID-based release names
    • Removed automatic migration of releases from helm 2 to helm 3 (helm 2.16 no longer compatible with client-go 1.18)
  5. Update prometheus-operator to latest master (which supports 1.18)

Motivation for the change:
Users should be able to use Operator SDK with the latest 1.18 features and libraries.

Other notes

  • Ansible molecule tests are still using 1.17 since a 1.18 version of bsycorp/kind doesn't exist
  • Slighly modified olm uninstall to use background propagation and wait for deletion after each delete call. This was required to make tests pass in 1.18.
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
no red flags to me

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants