-
- Notifications
You must be signed in to change notification settings - Fork 145
Feat/css grid integration tests #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits Select commit Hold shift + click to select a range
50d319d feat(grid): add auto-repeat tests, and fix auto and repeat logic in grid
jwxbond 365a8f3 feat(grid): add repeat() notation tests
jwxbond 805cb00 fix(grid): gridTemplateColumns repeat value
jwxbond 16fe91e fix(grid): duplicate line names
jwxbond df59044 feat(grid): add explicit track definition tests and fix auto track sizes
jwxbond e39f7bc feat(grid): add template advance tests and fix combines areas with li…
jwxbond 3374378 fix(grid): handles invalid area names
jwxbond 071802c fix: auto places grid-area unknown name
jwxbond 449a868 feat(grid): add grid gaps and fix rowGap/colGap support percentage
jwxbond 80ef081 fix:feat(grid): add grid track size tests and fix `sizes percentage …
jwxbond d163c14 fix: trak-sizing-basic `sizes auto tracks to content`
jwxbond 812fa88 fix: trak-sizing-basic `sizes auto tracks to content` part2
jwxbond 1f33f24 feat(grid): support minmax function
jwxbond 953a6b3 feat(grid): add `fractional (fr) units` tests and snapshots
jwxbond 1928d47 feat(grid): add `content-based sizing` tests & snapshots, and fix `re…
jwxbond 19c750a feat(grid): add `intrinsic track sizing` tests and snapshots
jwxbond 190a363 fix(grid): sizing sizes tracks to min-content, nested grid, empty c…
jwxbond 71b238f feat(grid): add `item aspect ratio` tests and snapshots, fix grid ite…
jwxbond e8f1622 feat(grid): add `item overflow` tests and snapshots
jwxbond 6290c16 feat(grid): support grid item margin, add `stretch alignment` tests a…
jwxbond a829148 feat(grid): support grid item margin, add `item margins` tests and sn…
jwxbond 06640dc fix(grid): correct spanning implicit track sizing
jwxbond ca2f0c9 feat(grid): support intrinsic sizing keywords for grid item width
jwxbond 024e4c8 feat(grid): add `min/max-content sizing` tests and snapshots
jwxbond 985a5ce feat(grid): support baseline/last baseline for grid item, add base li…
jwxbond 9d06b48 feat(grid): add `auto-placement algorithm` tests and snapshots
jwxbond 64817f5 feat(grid): add `area-based placement` tests and snapshots and suppor…
jwxbond 58904fb feat(grid): add `area-based placement` snapshots
jwxbond c2f7251 fix(grid): line-based case `places items with positive line numbers`
jwxbond bd06afb fix: grid-column-start: 0 is invalid in CSS Grid, invalid as `auto`
jwxbond 3acfe9f fix(grid): update snapshot
jwxbond 4922af6 fix(grid): parse place-self and preserve row-dense placement order
jwxbond c8fd38a feat: support relative offsets
jwxbond 3de1d59 feat(grid): add `ine-base` snapshots
jwxbond 9695b51 feat(grid): add `overlapping-item` tests and snapshots
jwxbond 3a08ccf fix: block-fit.ts `content-as-initial`
jwxbond 9b51e5a fix(grid): enable hit testing
jwxbond e82ccdc fix(grid): update hit-test.ts
jwxbond ade07d8 fix: compile error
jwxbond 534da23 fix: grid unit test `grid_computed_style_test.dart`
jwxbond File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the
.dart_tool/directory pattern: change.dart-tool/to.dart_tool/The directory created by Dart tooling is
.dart_tool/(with underscore), not.dart-tool/(with hyphen). Without the correct pattern, the actual Dart-generated directory will not be ignored.🤖 Prompt for AI Agents