fix: externalize Emotion #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Andarist commented May 22, 2022
| "coverage": "vitest --coverage", | ||
| "upgrade-interactive": "npm-check -u" | ||
| }, | ||
| "dependencies": {}, |
Contributor Author
There was a problem hiding this comment.
added to satisfy the type-checker in vite.config.ts as I think it's worth to include packageJson.dependencies there from the start to avoid future mistakes
Andarist commented May 22, 2022
Comment on lines +6 to +12
| const makeExternalPredicate = (externals: string[]) => { | ||
| if (externals.length === 0) { | ||
| return () => false; | ||
| } | ||
| const pattern = new RegExp(`^(${externals.join('|')})($|/)`); | ||
| return (id: string) => pattern.test(id); | ||
| }; |
Contributor Author
There was a problem hiding this comment.
Alternatively could be something like:
Suggested change
| const makeExternalPredicate = (externals: string[]) => { | |
| if (externals.length === 0) { | |
| return () => false; | |
| } | |
| const pattern = new RegExp(`^(${externals.join('|')})($|/)`); | |
| return (id: string) => pattern.test(id); | |
| }; | |
| const externalsPredicate = (id: string) => !id.startsWith('.') |
Andarist commented May 22, 2022
| '@emotion/unitless', | ||
| '@emotion/utils', | ||
| ], | ||
| external: makeExternalPredicate([ |
Contributor Author
There was a problem hiding this comment.
The problem was that external is only handling exact matches by default and you were also importing from @emotion/react/jsx-runtime and that dragged a copy of Emotion to the bundle.
| I ended up here as well -- adding any |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.