Skip to content

feat: replace date-fns formatting with formatDate callback #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 15, 2023
Merged

feat: replace date-fns formatting with formatDate callback #101

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aab5df2
feat!: introduce formatDate callback
stampaaaron Jun 15, 2023
66992a4
docs: add date formatting example
stampaaaron Jun 15, 2023
e54975d
chore: remove date-fns dependency
stampaaaron Jun 15, 2023
69b865c
chore: fix typing of format callback
stampaaaron Jun 15, 2023
92df745
doc: update readme about date formatting
stampaaaron Jun 15, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix typing of format callback
  • Loading branch information
@stampaaaron
stampaaaron committed Jun 15, 2023
commit 69b865cecdae5d44cf233d7c51377bb7db1630d0
2 changes: 1 addition & 1 deletion src/components/Timeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export type TimelineProps = {
items: TimelineItemsProps;
positioning?: Positioning;
minMarkerGap?: number;
formatDate?: (date: Date) => void;
formatDate?: (date: Date) => string;
customMarker?: ReactElement;
customPointer?: ReactElement;
styleConfig?: StyleConfig;
Expand Down
2 changes: 1 addition & 1 deletion src/components/TimelineItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export type TimelineItemProps = PropsWithChildren<{
className?: string;
title?: string;
date: Date | string;
formatDate?: (date: Date) => void;
formatDate?: (date: Date) => string;
customMarker?: ReactElement;
customPointer?: ReactElement;
}>;
Expand Down