Allow building gdal, dae, ffmpeg and obj plugins with /std:c++17 msvc flag #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
maksim-petukhou force-pushed the std-17-fix branch from 53e00d9 to acef2a5 Compare maksim-petukhou changed the title /std:c++17 msvc flag 
maksim-petukhou force-pushed the std-17-fix branch from acef2a5 to 13a0018 Compare maksim-petukhou changed the title /std:c++17 msvc flag /std:c++17 msvc flag 3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
auto_ptris removed in C++17. This PR fixes gdal and ffmpeg plugin in a similar way than dae plugin was fixed (see 863dee5), but also takes into account that__cplusplusalways reports199711Lin msvc when not using special flag/Zc:__cplusplus(see https://learn.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=msvc-170#remarks)ptr_funis also removed in C++17. That's why I provided C++17 compatible version ofstripfunction for obj plugin.