Skip to content

Conversation

hnakamur
Copy link
Contributor

@hnakamur hnakamur commented Jun 22, 2022

@zhuizhuhaomeng
Copy link
Contributor

@hnakamur you can add v1.23.0 to .travis.yml.

@hnakamur
Copy link
Contributor Author

Add patch for nginx 1.23.0 by hnakamur · Pull Request #24 · openresty/no-pool-nginx is needed to be merged for travis nginx 1.23.0 to be successful.

@zhuizhuhaomeng
Copy link
Contributor

@hnakamur no-pool-nginx.patch has been merged.

@zhuizhuhaomeng
Copy link
Contributor

@hnakamur would you please retrigger the travis?

@hnakamur
Copy link
Contributor Author

@zhuizhuhaomeng I tried to retrigger the travis, but the "Trigger build" menu in "More options" dropdown at https://app.travis-ci.com/github/openresty/srcache-nginx-module/jobs/574418725 is disabled.
Would you regtrigger the travis instead?

@zhuizhuhaomeng
Copy link
Contributor

zhuizhuhaomeng commented Jun 23, 2022

I can not retrigger the travis also. I think you need to add a new commit , eg: add one space in the travis.yml.

@zhuizhuhaomeng
Copy link
Contributor

@zhuizhuhaomeng I tried to retrigger the travis, but the "Trigger build" menu in "More options" dropdown at https://app.travis-ci.com/github/openresty/srcache-nginx-module/jobs/574418725 is disabled. Would you regtrigger the travis instead?

thanks god, I can retrigger the travis after I login travis-ci.com

@zhuizhuhaomeng
Copy link
Contributor

Hi @hnakamur thanks your contribution. I have approved this PR.
Because the following three modules are still not compatible with nginx-1.23.0 and the ci can not work properly, So I will not merge the PR for now.

lua-nginx-module headers-more-nginx-module ngx_http_redis 
@hnakamur
Copy link
Contributor Author

Thanks for reviewing and approving!

@zhuizhuhaomeng
Copy link
Contributor

@hnakamur t/private.t run failed.
function ngx_http_srcache_process_multi_header_lines still think the r->headers_out.headers is an array.
would you please fix it.

@zhuizhuhaomeng zhuizhuhaomeng merged commit be22ac0 into openresty:master Jun 28, 2022
@zhuizhuhaomeng
Copy link
Contributor

@hnakamur thank you for your contribution.
I have merged the PR.
The ci still can not pass due to other issues. We need other PRs to fix the ci.

@hnakamur hnakamur deleted the update_for_nginx_1_23_0 branch June 28, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants