add len parameter in update() of resty.md5 #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @sjnam Thanks for the patch! But will you add a test case to the existing test suite too? Thanks! |
| @agentzh I added a test case. Thanks! |
| @sjnam Awesome! I'll look into this as soon as I can manage :) Thanks a lot! |
| @sjnam Mind to add a note to README as well? ;) |
| @agentzh |
| @sjnam Cool. Thanks! |
zhuizhuhaomeng approved these changes Sep 5, 2021
zhuizhuhaomeng added a commit that referenced this pull request Sep 5, 2021
zhuizhuhaomeng added a commit that referenced this pull request Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When I use _M.update(self, s) in resty.md5, I had an case when len is not #s.
so, how about the following?
function _M.update(self, s, len)
return C.MD5_Update(self._ctx, s, len or #s) == 1
end