Skip to content

fix: Return MiddlewareResponse obj for rewrite #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 23, 2023
Merged

fix: Return MiddlewareResponse obj for rewrite #2159

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7bb63d8
fix: Return MiddlewareResponse for rewrite
taty2010 Jun 12, 2023
f46ab43
chore: remove console logs
taty2010 Jun 13, 2023
52b12a9
chore: added tests and updated logic to include init
taty2010 Jun 13, 2023
1ec8d01
Merge branch 'main' into tn-advMiddlewareRewrite
taty2010 Jun 13, 2023
4816efc
Merge branch 'main' into tn-advMiddlewareRewrite
taty2010 Jun 14, 2023
243330d
chore: revert selector back to original
taty2010 Jun 14, 2023
4199c23
fix: pass in new headers
taty2010 Jun 15, 2023
0689fca
chore: applyheader before response
taty2010 Jun 16, 2023
f181b44
chore: update tests remove header fix
taty2010 Jun 16, 2023
993cba6
chore: testing update
taty2010 Jun 16, 2023
3d3ac2a
Merge branch 'main' into tn-advMiddlewareRewrite
taty2010 Jun 16, 2023
23caa96
Merge branch 'main' into tn-advMiddlewareRewrite
taty2010 Jun 22, 2023
40ade6d
chore: removed undici import
taty2010 Jun 22, 2023
3a38588
chore: added undici import back
taty2010 Jun 22, 2023
f04c6b6
Merge branch 'main' into tn-advMiddlewareRewrite
taty2010 Jun 23, 2023
3353d66
Update demos/middleware/middleware.ts
taty2010 Jun 23, 2023
983c8fe
Update cypress/e2e/middleware/enhanced.cy.ts
taty2010 Jun 23, 2023
29e5502
chore: removed header override testing
taty2010 Jun 23, 2023
6a1e00d
chore: formatting
taty2010 Jun 23, 2023
f1c210d
chore: new line
taty2010 Jun 23, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: revert selector back to original
  • Loading branch information
@taty2010
taty2010 committed Jun 14, 2023
commit 243330d4a81e27d2b737206e72a860d3d64910c9
4 changes: 2 additions & 2 deletions demos/middleware/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export async function middleware(req: NextRequest) {
const message = `This was static (& escaping test &) but has been transformed in ${req.geo?.city}`

// Transform the response HTML and props
res.replaceText('h1[id=testing-rewrite]', message)
res.replaceText('#message', message)
res.setPageProp('message', message)
res.setPageProp('showAd', true)

Expand All @@ -46,7 +46,7 @@ export async function middleware(req: NextRequest) {
const message = `This was static (& escaping test &) but has been transformed in ${req.geo?.city}`

// Transform the response HTML and props
res.replaceText('h1[id=testing-rewrite]', message)
res.replaceText('#message', message)
res.setPageProp('message', message)
res.setPageProp('showAd', true)

Expand Down