Fix package names of FXML resources and controllers #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fix two errors in package names: 1. java.lang.IllegalStateException: Location is not set. The application loads the FXML resources relative to its own package org.openjfx.hellofx, but the resources are not found because they are in a different package, org.openjfx. The fix is either to get the resources using their absolute names, such as "/org/openjfx/primary.fxml", or to change their package name to org.openjfx.hellofx. This fix changes the package name. 2. java.lang.module.InvalidModuleDescriptorException: Package org.openjfx not found in module The FXML classes use reflection to load the controllers in org.openjfx.hellofx, but only the package org.openjfx, which contains no code, is open to it. Fix the module descriptor to open the correct package name of org.openjfx.hellofx. Fixes openjfx#39
jgneff changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix two errors in package names:
The application loads the FXML resources relative to its own package
org.openjfx.hellofx, but the resources are not found because they are in
a different package, org.openjfx. The fix is either to get the resources
using their absolute names, such as "/org/openjfx/primary.fxml", or to
change their package name to org.openjfx.hellofx. This fix changes the
package name.
Package org.openjfx not found in module
The FXML classes use reflection to load the controllers in
org.openjfx.hellofx, but only the package org.openjfx, which contains no
code, is open to it. Fix the module descriptor to open the correct
package name of org.openjfx.hellofx.
Fixes #39