Skip to content

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 9, 2025

Hi all,

The 'Runinfo info' parameters in compiler/c2/gvn/TestBitCompressValueTransform.java is unused, maybe we can remove the unused parameters.

Change has been verified locally on linux-x64, test-fix only, trivial fix, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8369490: Remove unused Runinfo parameters in compiler/c2/gvn/TestBitCompressValueTransform.java (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27720/head:pull/27720
$ git checkout pull/27720

Update a local copy of the PR:
$ git checkout pull/27720
$ git pull https://git.openjdk.org/jdk.git pull/27720/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27720

View PR using the GUI difftool:
$ git pr show -t 27720

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27720.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 9, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 9, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369490: Remove unused Runinfo parameters in compiler/c2/gvn/TestBitCompressValueTransform.java Reviewed-by: chagedorn, mhaessig 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 9, 2025
@openjdk
Copy link

openjdk bot commented Oct 9, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2025

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial, thanks for following up on that!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 9, 2025
Copy link
Contributor

@mhaessig mhaessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good and trivial. Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
3 participants