Skip to content

Conversation

Delawen
Copy link
Contributor

@Delawen Delawen commented Oct 9, 2025

Contains patches for: https://bugs.openjdk.org/browse/JDK-8363440
Fixes: https://bugs.openjdk.org/browse/JDK-8369418

Right now, the AOT Map displays the KlassTrainingData like this:

0x00000008002aa5e0: @@ KlassTrainingData 40 0x00000008002ac260: @@ KlassTrainingData 40 

which doesn't provide any context on what class is this training for.

Modify the AOT Map Logger so we can link the class to its training data:

0x00000008007d5940: @@ KlassTrainingData 40 jdk.internal.loader.BuiltinClassLoader 0x0000000800815398: @@ KlassTrainingData 40 java.lang.invoke.DirectMethodHandle 0x00000008008791f0: @@ KlassTrainingData 40 java.util.HashSet 0x00000008008bd980: @@ KlassTrainingData 40 java.lang.module.ModuleDescriptor$Exports 0x00000008008db8e8: @@ KlassTrainingData 40 java.lang.invoke.InvokerBytecodeGenerator 

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8369418: Identify owning class for KlassTrainingData in AOT map output (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27715/head:pull/27715
$ git checkout pull/27715

Update a local copy of the PR:
$ git checkout pull/27715
$ git pull https://git.openjdk.org/jdk.git pull/27715/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27715

View PR using the GUI difftool:
$ git pr show -t 27715

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27715.diff

Using Webrev

Link to Webrev Comment

@Delawen
Copy link
Contributor Author

Delawen commented Oct 9, 2025

Some of the KlassTrainingData will not reflect a class name because of https://mail.openjdk.org/pipermail/leyden-dev/2025-October/002764.html

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 9, 2025

👋 Welcome back Delawen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 9, 2025

@Delawen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369418: Identify owning class for KlassTrainingData in AOT map output Reviewed-by: iklam, adinn 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@adinn, @iklam) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 9, 2025
@openjdk
Copy link

openjdk bot commented Oct 9, 2025

@Delawen The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2025
@Delawen Delawen changed the title JDK-8369418: Add class name to KlassTrainingData aot map output JDK-8369418 Identify owning class for KlassTrainingData in AOT map output Oct 9, 2025
@openjdk openjdk bot changed the title JDK-8369418 Identify owning class for KlassTrainingData in AOT map output 8369418: Identify owning class for KlassTrainingData in AOT map output Oct 9, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2025

Webrevs

Copy link
Contributor

@adinn adinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@adinn
Copy link
Contributor

adinn commented Oct 9, 2025

@Delawen You need another review -- perhaps from @iklam?

@openjdk
Copy link

openjdk bot commented Oct 9, 2025

⚠️ @Delawen the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8369418 $ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name' $ git push 
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 9, 2025
#include "memory/allocation.hpp"
#include "memory/allStatic.hpp"
#include "oops/oopsHierarchy.hpp"
#include "oops/trainingData.hpp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I header files, if a type can be forward declared, we usually do not include the its header. In this case, we can use:

class KlassTrainingData;

instead.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 9, 2025
Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2025
@Delawen
Copy link
Contributor Author

Delawen commented Oct 10, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 10, 2025
@openjdk
Copy link

openjdk bot commented Oct 10, 2025

@Delawen
Your change (at version 5ee2f0e) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Oct 10, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 10, 2025

Going to push as commit f52aed6.
Since your change was applied there have been 69 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2025
@openjdk openjdk bot closed this Oct 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 10, 2025
@openjdk
Copy link

openjdk bot commented Oct 10, 2025

@jerboaa @Delawen Pushed as commit f52aed6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

4 participants