- Notifications
You must be signed in to change notification settings - Fork 6.1k
8369418: Identify owning class for KlassTrainingData in AOT map output #27715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some of the KlassTrainingData will not reflect a class name because of https://mail.openjdk.org/pipermail/leyden-dev/2025-October/002764.html |
👋 Welcome back Delawen! A progress list of the required criteria for merging this PR into |
@Delawen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 68 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@adinn, @iklam) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
#include "memory/allocation.hpp" | ||
#include "memory/allStatic.hpp" | ||
#include "oops/oopsHierarchy.hpp" | ||
#include "oops/trainingData.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I header files, if a type can be forward declared, we usually do not include the its header. In this case, we can use:
class KlassTrainingData;
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
/integrate |
/sponsor |
Going to push as commit f52aed6.
Your commit was automatically rebased without conflicts. |
Contains patches for: https://bugs.openjdk.org/browse/JDK-8363440
Fixes: https://bugs.openjdk.org/browse/JDK-8369418
Right now, the AOT Map displays the KlassTrainingData like this:
which doesn't provide any context on what class is this training for.
Modify the AOT Map Logger so we can link the class to its training data:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27715/head:pull/27715
$ git checkout pull/27715
Update a local copy of the PR:
$ git checkout pull/27715
$ git pull https://git.openjdk.org/jdk.git pull/27715/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27715
View PR using the GUI difftool:
$ git pr show -t 27715
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27715.diff
Using Webrev
Link to Webrev Comment