8369468: Rdtsc: Move getCPUIDBrandString_stub into VM_Version stub area

[xmas92]

Currently these stubs are created in Rdtsc::initialize which may be called from the first ElapsedCounter now call. This causes problems with lock ranks as we may be holding a lock while taking time, because we need to lock the code cache to create a stub.

I suggest we move the getCPUIDBrandString_stub next to the other VM_Version stubs and generate them together. This is done at the earliest point we can, right after the CodeCache system has been initialized.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8369468: Rdtsc: Move getCPUIDBrandString_stub into VM_Version stub area (Enhancement - P4)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27711/head:pull/27711
$ git checkout pull/27711

Update a local copy of the PR:
$ git checkout pull/27711
$ git pull https://git.openjdk.org/jdk.git pull/27711/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27711

View PR using the GUI difftool:
$ git pr show -t 27711

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27711.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369468: Rdtsc: Move getCPUIDBrandString_stub into VM_Version stub area Reviewed-by: mgronlun, kvn 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 13f460c: 8368677: acvp test should throw SkippedException when no ACVP-Server available
• 233d3a8: 8366244: TLS1.3 ChangeCipherSpec message received after the client's Finished message should trigger a connection abort with "unexpected message"
• 005877b: 8369236: testlibrary_tests/ir_framework/tests/TestCompileThreshold.java timed out
• ... and 12 more: https://git.openjdk.org/jdk/compare/0b81db1d38e69e6d8c73f22e4dae63ff5775852e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@xmas92 The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1cd0a069)

[vnkozlov]

Looks reasonable.