Skip to content

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Sep 23, 2025

Hi all,

The sub-test H3MalformedResponseTest.testMalformedResponse in test/jdk/java/net/httpclient/http3/H3MalformedResponseTest.java intermittent report java.util.concurrent.TimeoutException, espicial when this test run with other jtreg tests simultancely. This PR change the timeout vaule from 10 to 30 to make test run passed steady.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368373: Test H3MalformedResponseTest.testMalformedResponse intermittent timed out (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27447/head:pull/27447
$ git checkout pull/27447

Update a local copy of the PR:
$ git checkout pull/27447
$ git pull https://git.openjdk.org/jdk.git pull/27447/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27447

View PR using the GUI difftool:
$ git pr show -t 27447

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27447.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368373: Test H3MalformedResponseTest.testMalformedResponse intermittent timed out Reviewed-by: dfuchs, djelinski 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the net net-dev@openjdk.org label Sep 23, 2025
@openjdk
Copy link

openjdk bot commented Sep 23, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Sep 23, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 23, 2025
@sendaoYan
Copy link
Member Author

Thanks for the advices and reviews @vy @djelinski @dfuch

/integrate

@openjdk
Copy link

openjdk bot commented Sep 24, 2025

Going to push as commit 5350ce1.
Since your change was applied there have been 21 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 24, 2025
@openjdk openjdk bot closed this Sep 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 24, 2025
@openjdk
Copy link

openjdk bot commented Sep 24, 2025

@sendaoYan Pushed as commit 5350ce1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated net net-dev@openjdk.org

4 participants