added supported_extensions list to discovery #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
samdozor requested changes May 17, 2018
OpenGDPR_specification.md Outdated
| | ||
| `supported_extensions` | ||
| | ||
| **REQUIRED** array of extension keys as defined in 7.1.2. |
There was a problem hiding this comment.
- why is it required? If a processor does not support any extension - must they return an empty-list vs. null?
- is it worth noting that this is with the intention that requests could be federated?
There was a problem hiding this comment.
- It keeps it in line with the others: all required. Someone could conceivably have 0 supported public identities (passing an empty array) and one or more supported extensions. What do you think?
- I don't think it needs to be called out since it could work by aggregating the discovery info.
| Updated pull to update:
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.