Skip to content

Conversation

evansims
Copy link
Member

Description

  • Bumped dependency requirements for urllib3 to specify >= v1.26.19 or >= v2.2.2
  • Modified type hints in RESTResponse class to use urllib3.HTTPResponse instead of urllib3.BaseHTTPResponse
  • Added matrix testing for different urllib3 versions in GitHub Actions workflow

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected
@evansims evansims added the bug Something isn't working label Mar 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.42%. Comparing base (e07ce96) to head (358f7a7).

❌ Your project status has failed because the head coverage (70.42%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@ Coverage Diff @@ ## main #179 +/- ## ======================================= Coverage 70.42% 70.42% ======================================= Files 134 134 Lines 10798 10798 ======================================= Hits 7605 7605 Misses 3193 3193 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@evansims evansims force-pushed the fix/python/replace-basehttpresponse branch from 6294888 to 17378ee Compare March 26, 2025 14:22
@evansims evansims marked this pull request as ready for review March 26, 2025 14:23
@evansims evansims requested a review from a team as a code owner March 26, 2025 14:23
@evansims evansims force-pushed the fix/python/replace-basehttpresponse branch from 17378ee to 358f7a7 Compare March 26, 2025 14:29
@evansims evansims added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit 46214ab Mar 26, 2025
23 checks passed
@evansims evansims deleted the fix/python/replace-basehttpresponse branch March 26, 2025 14:34
@ewanharris ewanharris mentioned this pull request Apr 30, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

3 participants