Skip to content

Conversation

evansims
Copy link
Member

@evansims evansims commented Mar 25, 2025

Description

  • Improved client request duration handling.
  • Fixed attribute filtering issue in some configurations.
  • Updated ClientConfiguration to include telemetry configuration (like Configuration.)
  • Enhanced tests to validate new telemetry attributes and ensure correct duration calculations.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected
Improved client request duration handling. Fixed attribute filtering issue in some configurations. Updated ClientConfiguration to include telemetry configuration (like Configuration.) Enhanced tests to validate new telemetry attributes and ensure correct duration calculations.
@evansims evansims added the bug Something isn't working label Mar 25, 2025
@evansims evansims marked this pull request as ready for review March 25, 2025 06:22
@evansims evansims requested a review from a team as a code owner March 25, 2025 06:22
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.42%. Comparing base (cefa972) to head (b57c15b).

❌ Your project status has failed because the head coverage (70.42%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@ Coverage Diff @@ ## main #177 +/- ## ========================================== + Coverage 70.37% 70.42% +0.05%  ========================================== Files 134 134 Lines 10792 10798 +6 ========================================== + Hits 7595 7605 +10  + Misses 3197 3193 -4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@evansims evansims added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit cde5145 Mar 25, 2025
17 checks passed
@evansims evansims deleted the fix/telemetry-attributes branch March 25, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

3 participants