This repository was archived by the owner on Aug 1, 2024. It is now read-only.
Fix upgrading by bumping pip-tools; use python 3.5 for CI #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| I'm not totally sure if downgrading Python from 3.6 to 3.5 is correct, since this isn't deployed per se, but it would put it in line with our other repos. |
Contributor
| @timmc-edx: I'd have the same question about Python 3.5 vs 3.6. It would be great if we could have a documented decision around this for people to refer to. |
jmbowman approved these changes Mar 11, 2020
Contributor
jmbowman left a comment
jmbowman left a comment There was a problem hiding this comment.
Switching to 3.5 for consistency seems like a good idea. We're likely to go to 3.8 next rather than 3.6 anyway, so not sure we gain much from 3.6 testing.
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.