This repository was archived by the owner on Aug 1, 2024. It is now read-only.
Update microfrontend.yml image to be Node:12 version #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
iloveagent57 approved these changes Dec 6, 2019
Contributor
iloveagent57 left a comment
iloveagent57 left a comment There was a problem hiding this comment.
LGTM (assuming tests pass)
| Looks like the PR travis build took 50 mins to run and was canceled due to exceeding a build time limit. Is this normal for devstack? (I just restarted the travis build) |
Contributor
| @abutterworth Unfortunately, it is normal for devstack. I don't know of a workaround; I ended just merging my last devstack PR with tests failing. @jmbowman mentioned that the fix would likely be making provisioning faster. |
Contributor
| Looks like @jinder1s is/was working on the issue: https://github.com/edx/devstack/pull/458 |
matthugs approved these changes Dec 9, 2019
matthugs suggested changes Dec 9, 2019
Contributor
matthugs left a comment
matthugs left a comment There was a problem hiding this comment.
Oh wait actually I almost forgot
schenedx force-pushed the schen/gradebook_node12 branch from 1be628a to f8776e3 Compare schenedx changed the title matthugs approved these changes Dec 9, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Update the gradebook container node version from 10 to 12
@edx/masters-devs Please review.