Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

Conversation

@mostafahussein
Copy link
Contributor

This PR adds a check for mongodb to ensure that the container is running before continue the provision process

@openedx-webhooks
Copy link

Thanks for the pull request, @mostafahussein! I've created OSPR-3870 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Oct 3, 2019
@natabene
Copy link

natabene commented Oct 3, 2019

@mostafahussein Thank you for your contribution. @jmbowman This is ready for your review.

do
printf "."
sleep 1
done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this block below echo -e "MySQL ready" below? MongoDB is usually up and running by the end of the 20-second sleep below, whereas putting this here might slow down startup a little.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@natabene
Copy link

@mostafahussein Are you still interested in pursuing this and implementing Jeremy's feedback?

@mostafahussein
Copy link
Contributor Author

@natabene Sorry for the late follow-up, I have updated the code as @jmbowman suggested.

Copy link
Contributor

@jmbowman jmbowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mostafahussein
Copy link
Contributor Author

@jmbowman the current ci error is not related to the pr modification itself

@jmbowman
Copy link
Contributor

The Travis failure is a pre-existing problem with the job taking a little too long, merging.

@jmbowman jmbowman merged commit f4c328a into openedx-unsupported:master Oct 28, 2019
@openedx-webhooks
Copy link

@mostafahussein 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

merged open-source-contribution PR author is not from Axim or 2U

4 participants