Reduce maintenance burden by letting setup-go track our Go versions #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tianon requested review from cyphar, jonjohnsonjr, sajayantony, stevvooe and sudo-bmitch as code owners `actions/setup-go` supports "stable" and "oldstable" as automatic aliases for the latest release and the previous to latest release, which was our intent with two of these three hard-coded versions. The third is hard-coded to match our `go.mod`, which `actions/setup-go` *also* supports reading from, so we can be completely DRY here. Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
Member Author
|
sudo-bmitch approved these changes Dec 13, 2024
sajayantony approved these changes Jan 9, 2025
| I wanted to implement the same thing in runtime-spec but found out it lacks go.mod so we can't. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
actions/setup-gosupports "stable" and "oldstable" as automatic aliases for the latest release and the previous to latest release, which was our intent with two of these three hard-coded versions. The third is hard-coded to match ourgo.mod, whichactions/setup-goalso supports reading from, so we can be completely DRY here.See #1225 (comment)