Changed: Sanitize URI regular expressions (OID & License Plate) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits March 20, 2024 02:25
- License plate is considered valid if it has 7 or 8 numbers
edurodriguesdias changed the title 
eudiegoborgs approved these changes Mar 21, 2024
ricardosparapan approved these changes Mar 21, 2024
leocavalcante approved these changes Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
About OID, there are instances where we encounter mismatches in sanitizing URIs containing more than 24 characters. This issue results in only a portion of our path parameters being hidden (specifically, the first 24 characters), while the remainder remains visible.
Examples below:
Furthermore, the current regular expression for license plates does not limit the number of characters, leading to a mismatch when the initial path parameter satisfies the regular expression rule (3 letters, 1 digit, 1 letter, and 2 digits at the end).
What's changed?
,) after the regular expression quantifier. This modification allows for the capture of OIDs longer than 24 characters./.Tests Evidence
After the changes, we observe that the is entire hidden.
The license plate regular expression will no longer conflict with OID:
In the case of a real license plate:
When the beginning of the string captured looks like a license plate but has more than 7 or 8 characters, it will be treated as an OID.
Unit tests:
