Fix: Change tracer span name #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gustavofreze approved these changes Jan 18, 2024
fix: changing trace span name
edurodriguesdias force-pushed the fix-change-trace-name branch from f2dff5d to 7578d8f Compare 
gustavobgama approved these changes Jan 18, 2024
weslen-teche approved these changes Jan 18, 2024
enicioli approved these changes Jan 19, 2024
lucas-angeli-gimenes approved these changes Jan 19, 2024
luizmanhani approved these changes Jan 22, 2024
leocavalcante approved these changes Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Currently, we send the name of the trace to OTEL based on our request path, and Dynatrace considers paths with the same structure as identical.
For instance:
GET /bin/
PUT /bin/
Although the names are the same, the resources are different. Currently, Dynatrace groups all requests between these two paths under the same metric because the paths are identical.
Proposal Solution
To address this issue, we just concatenate the HTTP verb at the beginning of every path. This adjustment will prevent Dynatrace, or any other observability tool utilizing path as the trace name, from grouping our metrics under the same trace.
With this solution, our endpoint metrics will be structured as follows: