Fix Thrift UDP Transport #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
feroliveira88 approved these changes Dec 19, 2024
wilcorrea approved these changes Dec 19, 2024
gustavobgama approved these changes Dec 19, 2024
weslen-teche approved these changes Dec 19, 2024
lucas-angeli-gimenes force-pushed the fix-thrift-udp-transport branch from 5f6fab9 to f54f298 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously, when an exception was thrown during the execution of the
doOpenmethod, the coroutine responsible for traces dispatch (loop method) was destroyed. This resulted in the indefinite suspension of all calls to$this->chan->push(), causing the coroutines involved to “freeze”.With this change, the push coroutine is maintained even with exceptions, ensuring that the flow is not interrupted. In addition, a timeout has been introduced for calls to
$this->chan->push()to avoid indefinite blockages and ensure that the coroutines are properly released in the event of transmission failures.