Skip to content

fix resource type warning #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2024
Merged

fix resource type warning #12

merged 1 commit into from
May 21, 2024

Conversation

luizmanhani
Copy link

@luizmanhani luizmanhani commented May 21, 2024 •
edited
Loading

fix resource type warning:
`Warning: "resource" is not a supported builtin type and will be interpreted as a class name. Write "\Jaeger\resource" or import the class with "use" to suppress this warning in /app/vendor/hyperf/tracer/class_map/ThriftUdpTransport.php on line 29

PHP Warning: "resource" is not a supported builtin type and will be interpreted as a class name. Write "\Jaeger\resource" or import the class with "use" to suppress this warning in /app/vendor/hyperf/tracer/class_map/ThriftUdpTransport.php on line 29`

as the rfcs says the resouce type hint:

No type hint for resources is added, as this would prevent moving from resources to objects for existing extensions, which some have already done (e.g. GMP).

https://wiki.php.net/rfc/scalar_type_hints
https://stackoverflow.com/a/38430606
@leocavalcante leocavalcante merged commit c1cca00 into opencodeco:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@luizmanhani @leocavalcante @tiagoamemiya @lucas-angeli-gimenes