Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Reduces generated code #166

Merged
merged 12 commits into from
May 9, 2023
Merged

Reduces generated code #166

merged 12 commits into from
May 9, 2023

Conversation

spacether
Copy link
Contributor

@spacether spacether commented May 5, 2023 •
edited
Loading

  • api_client classes turned into dataclasses
  • deleted unneeded imports
  • Schema classes __new__ no longer generated for AnyType schemas

Breaking Changes:
ApiClient inputs:

  • default_headers must now be passed in to ApiClient rather than cookie and header_name and header_value
  • schema_config -> schema_configuration

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.
@spacether spacether merged commit 23f9a9e into 3_0_0 May 9, 2023
@spacether spacether deleted the v3_reduce_generated_code branch May 9, 2023 03:31
spacether added a commit that referenced this pull request May 17, 2023
@spacether
Reduces generated code (#166)
816a9b6 
* Converts PrefixSeparatorIterator, Api, and Encoding into dataclasses * ApiClient converted to dataclass * Removes __call_api * Removes unneeded type imports from header * Removes unneeded imports from headers * Removes unneeded imports in responses when they have no content or headers * Removes unneeded header imports * Removes pyi files * Removes functools import * Stops generating new for anytype schemas * Samples regenerated * Fixes this_package security tests
@spacether spacether added this to the 3.0.0 milestone May 17, 2023
spacether added a commit that referenced this pull request May 31, 2023
@spacether
Reduces generated code (#166)
7a26012 
* Converts PrefixSeparatorIterator, Api, and Encoding into dataclasses * ApiClient converted to dataclass * Removes __call_api * Removes unneeded type imports from header * Removes unneeded imports from headers * Removes unneeded imports in responses when they have no content or headers * Removes unneeded header imports * Removes pyi files * Removes functools import * Stops generating new for anytype schemas * Samples regenerated * Fixes this_package security tests
spacether added a commit that referenced this pull request Jun 8, 2023
@spacether
Reduces generated code (#166)
87da2d7 
* Converts PrefixSeparatorIterator, Api, and Encoding into dataclasses * ApiClient converted to dataclass * Removes __call_api * Removes unneeded type imports from header * Removes unneeded imports from headers * Removes unneeded imports in responses when they have no content or headers * Removes unneeded header imports * Removes pyi files * Removes functools import * Stops generating new for anytype schemas * Samples regenerated * Fixes this_package security tests
spacether added a commit that referenced this pull request Aug 16, 2023
@spacether
Reduces generated code (#166)
16d8fe1 
* Converts PrefixSeparatorIterator, Api, and Encoding into dataclasses * ApiClient converted to dataclass * Removes __call_api * Removes unneeded type imports from header * Removes unneeded imports from headers * Removes unneeded imports in responses when they have no content or headers * Removes unneeded header imports * Removes pyi files * Removes functools import * Stops generating new for anytype schemas * Samples regenerated * Fixes this_package security tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant

@spacether