Skip to content

Conversation

@kennyhsu5
Copy link
Collaborator

@kennyhsu5 kennyhsu5 commented Mar 11, 2022

Reverts #76

Seeing a couple unit tests (test_file_upload, test_engine_search_url_composition_azure_no_operation) failing with this change.

@kennyhsu5 kennyhsu5 requested review from hallacy and hponde and removed request for hallacy and hponde March 11, 2022 21:25
Copy link
Collaborator

@hponde hponde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reverts are almost always safe. I did not look at the contents much

@kennyhsu5 kennyhsu5 merged commit 718e7a4 into main Mar 11, 2022
@kennyhsu5 kennyhsu5 deleted the revert-76-azure-finetune branch March 11, 2022 22:12
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants