Skip to content

Conversation

@iaalm
Copy link
Contributor

@iaalm iaalm commented Mar 30, 2023

The Azure API need to pass parameter engine. Follow the pattern Completion.create to make model optional and add engine as a parameter too.

Tested on Azure OpenAI API passed with

openapi api chat_completions.create -e chatgpt -g user "hello" 
@iaalm iaalm changed the title Add support for azure openai chat completion API [Azure] CLI: Add support for azure openai chat completion API Mar 30, 2023
@hallacy hallacy requested a review from athyuttamre March 30, 2023 18:36
@iaalm
Copy link
Contributor Author

iaalm commented Apr 4, 2023

@athyuttamre could you help review?

Copy link

@athyuttamre athyuttamre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two non-blocking comments, thanks for the PR!

@iaalm
Copy link
Contributor Author

iaalm commented Apr 4, 2023

@athyuttamre Thank you for the review. Updated based on your comment.

Copy link

@athyuttamre athyuttamre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can cut a new release immediately or we can wait for other PRs (#337) from Microsoft to land. What do you prefer?

@iaalm
Copy link
Contributor Author

iaalm commented Apr 4, 2023

@athyuttamre Both should work. As this one works on its own, maybe we can merge it now?

@athyuttamre athyuttamre merged commit ed821c8 into openai:main Apr 4, 2023
@athyuttamre
Copy link

Great! I need a stamp from a teammate to publish a version, will do so once this is approved: #373.

@athyuttamre
Copy link

This has been published in https://pypi.org/project/openai/0.27.4/.

davedittrich pushed a commit to davedittrich/openai-python that referenced this pull request Nov 14, 2023
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants