[deprecated]: remove unused/deprecated code #345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Remove unused variables and imports * Add some variables to `__all__` * Remove redundant parenthesis
GLEF1X changed the title 
hallacy approved these changes Mar 30, 2023
| rheaders, | ||
| ) | ||
| | ||
| def request_headers( |
There was a problem hiding this comment.
Nit: can you check if the call in line 490 needs to get updated based on this?
There was a problem hiding this comment.
Yep, thank you for the review. It's indeed a bug that I overlooked. I've just fixed it in dc8feeb
I was using a couple of linters, and It's a good idea to integrate some into this project. For instance, I saw a pretty good configuration in evals, so contributors can follow the same code style. Tools like |
| It's too bad this was never merged; the SDK has been entirely rewritten since. |
safa0 pushed a commit to safa0/openai-agents-python that referenced this pull request Apr 27, 2025
Towards openai#345 ## Summary: Using a `dict` or `Mapping` isn't strict-mode compliant. But we were checking for the literal `True` whereas the value can also be an array, for example. Fix that. ## Test Plan: Unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.