Skip to content

Fix Gemini API content filter handling #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Fix Gemini API content filter handling #746

merged 1 commit into from
May 23, 2025
+51 −5

Conversation

@rm-openai
Copy link
Collaborator

@rm-openai rm-openai commented May 23, 2025 •
edited
Loading

Summary

  • avoid AttributeError when Gemini API returns None for chat message
  • return empty output if message is filtered
  • add regression test

Testing

  • make format
  • make lint
  • make mypy
  • make tests

Towards #744
@rm-openai rm-openai requested a review from pakrym-oai May 23, 2025 16:52
@rm-openai rm-openai merged commit 6e078bf into main May 23, 2025
5 checks passed
@rm-openai rm-openai deleted the codex/fix-attributeerror-with-gemini-api-and-tools branch May 23, 2025 17:00
@ghost
Copy link

ghost commented May 25, 2025

THIS IS AMAZING!!!!!! OH WOUW!!!!!
KatHaruto pushed a commit to KatHaruto/openai-agents-python that referenced this pull request Jun 10, 2025
@rm-openai @KatHaruto
Fix Gemini API content filter handling (openai#746)
3b85e34 
- avoid AttributeError when Gemini API returns `None` for chat message - return empty output if message is filtered - add regression test - `make format` - `make lint` - `make mypy` - `make tests` Towards openai#744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex

3 participants

@rm-openai @pakrym-oai