fix(usage): error usage format in streaming #61
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @rm-openai Please review this pr to fix the current issue where the stream response is not tracking properly. |
This was referenced Mar 12, 2025
rm-openai reviewed Mar 12, 2025
| Waiting on this to be merged asap |
| FYI I put out #112 so that we can merge this faster |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In the
stream_response, forgot to modify the format of usage.Why this error occur
in
_run_single_turn_stream(run.py), treat the usage asResponseUsage, but in fact the usage isCompletionUsage, because forgot to modify the format of usage instream_response(openai_chatcompletions.py).fix #63