fix: correct typo in README regarding tool responses #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Hi, the changes in your PR appears to duplicate the modifications already proposed in PR #4 |
Contributor Author
| Hi @notV3NOM , PR #4 seems quite cluttered with duplicate or overlapping changes. |
Contributor Author
| Hi @rm-openai, could you please review my PR when you have a moment? |
rm-openai approved these changes Mar 11, 2025
DIZ-admin pushed a commit to DIZ-admin/openai-agents-python that referenced this pull request Nov 18, 2025
Implemented DRY principle for event logging with EventEmitter class. Features: - EventEmitter class for centralized event handling - Standardized Event structure with type, severity, context - EventType and EventSeverity enums for type safety - Convenience methods (emit_started, emit_completed, emit_failed, etc.) - Automatic context enrichment with session/batch IDs Refactored Components: - validation_report.py - Replaced direct logger calls with EventEmitter Benefits: - Eliminates duplicate logger calls (~40% code reduction) - Consistent event structure across all components - Type-safe event definitions - Easy to add metrics/monitoring integration - Improved maintainability Tests: 18/18 passing Resolves: openai#13 (HIGH priority) Impact: Improves code maintainability and reduces duplication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
"We process the tool calls (if any) and append the tool responses messsages."
→ "We process the tool calls (if any) and append the tool response messages." (typo: "messsages" → "messages")
"If the response has a final output (see below for the more on this), we return it and end the loop."
→ "If the response has a final output (see below for more on this), we return it and end the loop." (remove "the")