Fix #980 Chat Completions: fails with function name for tool_choice parameter w/ streaming enabled #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…arameter w/ streaming enabled
seratch commented Jul 23, 2025
seratch commented Jul 23, 2025
| responses_tool_choice = OpenAIResponsesConverter.convert_tool_choice( | ||
| model_settings.tool_choice | ||
| ) | ||
| if responses_tool_choice is None or responses_tool_choice == NOT_GIVEN: |
There was a problem hiding this comment.
The essential changes here are 1) use Converter.convert_tool_choice 2) cover responses_tool_choice is None pattern. Added more detailed comments about why it's necessary but happy to adjust the style if necessary
| Hello, following up on this PR. Do we have an ETA to get it merged? |
| @rm-openai Can you review this before next release? I think this should be safe enough to merge. |
rm-openai approved these changes Aug 1, 2025
vcshih pushed a commit to veris-ai/openai-agents-python that referenced this pull request Aug 15, 2025
…oice parameter w/ streaming enabled (openai#1206) This pull request resolves openai#980 simple code snippet to do tests: ```python import asyncio from openai.types.responses import ResponseTextDeltaEvent from agents import Agent, ModelSettings, Runner, function_tool, set_default_openai_api set_default_openai_api("chat_completions") @function_tool def say_hello(): print("Hello, world!") return "Hello, world!" async def main(): agent = Agent( name="Joker", instructions="You are a helpful assistant.", model_settings=ModelSettings(tool_choice="say_hello"), tools=[say_hello], ) result = Runner.run_streamed(agent, input="Please tell me 5 jokes.") async for event in result.stream_events(): if event.type == "raw_response_event" and isinstance(event.data, ResponseTextDeltaEvent): print(event.data.delta, end="", flush=True) if __name__ == "__main__": asyncio.run(main()) ```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request resolves #980
simple code snippet to do tests: