Skip to content

Conversation

@seratch
Copy link
Member

@seratch seratch commented Jul 10, 2025

This pull request adds a new script for docs, which generates missing ref/**/*.md files. The script can be executed when you run make build-docs command. The script does not do:

  • overwrite the existing ones
  • create files for _XXX.py and __init__.py

Note that the title part is generated like tool_context to Tool Context. openai_provider will be Openai Provider, so some of them needs a little manual work to adjust.

The direct need is to add tool_context.md for #1043 but it should be useful for future maintenance.

@seratch seratch requested a review from rm-openai July 10, 2025 03:30
@seratch seratch added the documentation Improvements or additions to documentation label Jul 10, 2025
Copy link
Collaborator

@rm-openai rm-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @seratch the code looks totally fine but I actually don't get why we need this? Why can't the files just be hand-written, takes like 5 seconds lol

@seratch
Copy link
Member Author

seratch commented Jul 14, 2025

@rm-openai indeed, creating a single file takes only a few seconds, but checking which files are missing (like this PR does) could take much longer and automation script can do better job.

Copy link

@waveformer1984 waveformer1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes across all projects

@seratch seratch merged commit c5d5010 into main Jul 21, 2025
5 checks passed
@seratch seratch deleted the automate-mkdocstrings-file-creation branch July 21, 2025 23:35
vcshih pushed a commit to veris-ai/openai-agents-python that referenced this pull request Aug 15, 2025
This pull request adds a new script for docs, which generates missing `ref/**/*.md` files. The script can be executed when you run `make build-docs` command. The script does not do: - overwrite the existing ones - create files for _XXX.py and `__init__.py` Note that the title part is generated like `tool_context` to `Tool Context`. `openai_provider` will be `Openai Provider`, so some of them needs a little manual work to adjust. The direct need is to add `tool_context.md` for openai#1043 but it should be useful for future maintenance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

4 participants