Skip to content

Conversation

MillionIntegrals
Copy link
Contributor

I've updated mujoco-py for new major version MuJoCo 2.0. I needed to update the wrappers and header file parsing a bit because of the C level API change on the MuJoCo side.

The library compiles and all the tests pass.

One issue I found is that in one of the tests the depth image rendered has a bit of difference between Mac and Linux. Don't know if that's a dealbreaker in any way.

@mateuszlitwin
Copy link

We probably want to test this branch internally before merging. I will be happy to use it for my new model.

@machinaut
Copy link
Contributor

@mateuszlitwin it would be good to make sure this is compatible with https://github.com/openai/spinningup as well.

spinningup could pin a version, though.

@mateuszlitwin
Copy link

mateuszlitwin commented Mar 14, 2019

I was actually planning to try spinning up, I will use mujoco 2.

@mateuszlitwin
Copy link

Okay, I gave spinningup a spin with mujoco 2.0.2 and it seems to work.

So far I tried:

python -m spinup.run test_policy /Users/mlitwin/workspace/spinningup/spinningup/data/mujocotest/mujocotest_s0 
Copy link
Contributor

@welinder welinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MillionIntegrals MillionIntegrals merged commit d980119 into master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants