codex-rs: have ctrl+D only quit if input buffer is empty #1337
+34 −6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I am used to using ctrl+d to delete the character to the right of the cursor (this is a default emacs keybind, and works on most terminals), and I keep accidentally killing my codex windows. This change fixes this (and allows the use of ctrl-d to delete a character to the right of the cursor as well). This is slightly related to issue openai#1245, which discusses using ctrl+c (twice) as a method of quitting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I am used to using ctrl+d to delete the character to the right of the cursor (this is a default emacs keybind, and works on most terminals), and I keep accidentally killing my codex windows. This change fixes this (and allows the use of ctrl-d to delete a character to the right of the cursor as well).
This is slightly related to issue #1245, which discusses using ctrl+c (twice) as a method of quitting.