Skip to content

Conversation

@ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Apr 24, 2025

1st part of #2074

Changes

This PR adds k8s container resource related metrics that are already in use by the Opentelemetry Collector.

Related to #1032

I suggest to change the cpu_limit to cpu.limit since it makes sense to have a common k8s.container.cpu. namespace.

The following metrics are added:

Old (Collector) changed New
k8s.container.cpu_limit k8s.container.cpu.limit
k8s.container.cpu_request k8s.container.cpu.request
k8s.container.memory_limit k8s.container.memory.limit
k8s.container.memory_request k8s.container.memory.request
k8s.container.storage_limit k8s.container.storage.limit
k8s.container.storage_request k8s.container.storage.request
k8s.container.ephemeralstorage_limit k8s.container.ephemeral_storage.limit
k8s.container.ephemeralstorage_request k8s.container.ephemeral_storage.request

Merge requirement checklist

@ChrsMark ChrsMark requested review from a team as code owners April 24, 2025 14:14
@github-actions github-actions bot added the enhancement New feature or request label Apr 24, 2025
@ChrsMark ChrsMark force-pushed the add_k8s_container_metrics branch from cffdcbe to 628a714 Compare April 24, 2025 14:15
@ChrsMark ChrsMark moved this to In Review in K8s SemConv SIG Apr 24, 2025
@ChrsMark ChrsMark moved this from Untriaged to Awaiting SIG approval in Semantic Conventions Triage Apr 24, 2025
@ChrsMark ChrsMark force-pushed the add_k8s_container_metrics branch from 628a714 to 26c97a6 Compare April 25, 2025 07:10
@ChrsMark ChrsMark force-pushed the add_k8s_container_metrics branch from a51935d to 1db53f2 Compare April 28, 2025 10:51
@ChrsMark
Copy link
Member Author

ChrsMark commented May 5, 2025

@open-telemetry/semconv-k8s-approvers please take a look.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 21, 2025
@ChrsMark
Copy link
Member Author

Still valid

@github-actions github-actions bot removed the Stale label May 22, 2025
@ChrsMark ChrsMark requested a review from a team May 28, 2025 07:26
@ChrsMark ChrsMark moved this from Awaiting SIG approval to Needs More Approval in Semantic Conventions Triage May 28, 2025
@ChrsMark
Copy link
Member Author

@open-telemetry/specs-semconv-approvers @open-telemetry/specs-semconv-maintainers please take a look

@lmolkova lmolkova moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage May 29, 2025
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark added 3 commits May 29, 2025 11:30
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark force-pushed the add_k8s_container_metrics branch from 482f2e4 to cbd3b7e Compare May 29, 2025 08:30
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@github-project-automation github-project-automation bot moved this from Ready to be Merged to Needs More Approval in Semantic Conventions Triage May 29, 2025
@jsuereth jsuereth enabled auto-merge May 29, 2025 13:45
@jsuereth jsuereth added this pull request to the merge queue May 29, 2025
Merged via the queue into open-telemetry:main with commit a05b3ec May 29, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in K8s SemConv SIG May 29, 2025
jherbage pushed a commit to jherbage/semantic-conventions that referenced this pull request Jul 1, 2025
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:k8s enhancement New feature or request

5 participants